Stephan14 commented on code in PR #12308:
URL: https://github.com/apache/kafka/pull/12308#discussion_r928195459
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -1300,7 +1304,9 @@ class GroupCoordinator(val brokerId: Int,
completeAndScheduleNextHeartbeatExpiration(group, member)
val knownStaticMember = group.get(newMemberId)
- group.updateMember(knownStaticMember, protocols, responseCallback)
+ val oldRebalanceTimeoutMs = knownStaticMember.rebalanceTimeoutMs
+ val oldSessionTimeoutMs = knownStaticMember.sessionTimeoutMs
+ group.updateMember(knownStaticMember, protocols, rebalanceTimeoutMs,
sessionTimeoutMs, responseCallback)
Review Comment:
I have add unit test about persistence failed after join group successfully
in `GroupCoordinatorTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
