cadonna commented on PR #12285: URL: https://github.com/apache/kafka/pull/12285#issuecomment-1195567473
I agree that the migration should be done quickly. As far as I understand @clolov plans to do the whole migration quickly. Is this correct? If this is the case, I do not see the issue with making the migration incrementally for the sake of smaller PRs that are easier reviewed. If you create one big PR for the migration you might run into the issue that during the review other PRs add tests in JUnit4. You would need to rebase and extend the PR to get green builds. I agree that we should get the migration from EasyMock/PowerMock to Mockito done before we do the migration from JUnit4 to JUnit5 to make the reviews simpler. So our option now are: 1. Revert this PR, do the migration to Mockito incrementally, and do the migration to JUnit 5 in one shot 2. Do the change in the builds to allow JUnit 5 along with JUnit 4 and do both migrations incrementally. 3. Do the change in the builds to allow JUnit 5 along with JUnit 4, migrate to Mockito, and then migrate all tests to JUnit 5. For options 2 and 3 committers should be made aware to only accept JUnit 5 tests in new PRs. That should be easy for Streams. I am in favor of 3 because it happened to me that I already added some tests in JUnit5 in some of my PRs because I was not aware that JUnit 4 and JUnit 5 do not run alongside each other in our builds. Migrating the JUnit 5 tests to JUnit 4 in my PRs do not seem to be a big deal, though. I am also fine with option 1. Option 2 seems the oddest to me. I would like to know the preferences of @clolov and @divijvaidya since they are driving this migration? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
