mumrah commented on PR #12403: URL: https://github.com/apache/kafka/pull/12403#issuecomment-1195746529
Hey @cmccabe, thanks for the review! I agree it's a bit weird to return the completed feature here from the authorizer calls. I tried a few different approaches, and having all the handlers return the same type seemed to be a simple way to fix the error handling. The main issue I'm solving here is adding the final `whenComplete` to handle errors in completion handlers (which used to be `whenComplete`, but are now `handle` calls). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org