zigarn commented on code in PR #12434:
URL: https://github.com/apache/kafka/pull/12434#discussion_r932924464
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestServerTest.java:
##########
@@ -368,33 +414,26 @@ private void checkCustomizedHttpResponseHeaders(String
headerConfig, Map<String,
doReturn(Arrays.asList("a", "b")).when(herder).connectors();
server = new RestServer(workerConfig);
- try {
- server.initializeServer();
- server.initializeResources(herder);
- HttpRequest request = new HttpGet("/connectors");
- try (CloseableHttpClient httpClient = HttpClients.createMinimal())
{
- HttpHost httpHost = new
HttpHost(server.advertisedUrl().getHost(), server.advertisedUrl().getPort());
- try (CloseableHttpResponse response =
httpClient.execute(httpHost, request)) {
- Assert.assertEquals(200,
response.getStatusLine().getStatusCode());
- if (!headerConfig.isEmpty()) {
- expectedHeaders.forEach((k, v) ->
-
Assert.assertEquals(response.getFirstHeader(k).getValue(), v));
- } else {
-
Assert.assertNull(response.getFirstHeader("X-Frame-Options"));
- }
- }
- }
- } finally {
- server.stop();
- server = null;
+ server.initializeServer();
+ server.initializeResources(herder);
+ HttpRequest request = new HttpGet("/connectors");
+ httpClient = HttpClients.createMinimal();
+ HttpHost httpHost = new HttpHost(server.advertisedUrl().getHost(),
server.advertisedUrl().getPort());
+ response = httpClient.execute(httpHost, request);
+ Assert.assertEquals(200, response.getStatusLine().getStatusCode());
+ if (!headerConfig.isEmpty()) {
+ expectedHeaders.forEach((k, v) ->
+ Assert.assertEquals(response.getFirstHeader(k).getValue(),
v));
+ } else {
+ Assert.assertNull(response.getFirstHeader("X-Frame-Options"));
}
}
private String executeGet(String host, int port, String endpoint) throws
IOException {
HttpRequest request = new HttpGet(endpoint);
- CloseableHttpClient httpClient = HttpClients.createMinimal();
+ httpClient = HttpClients.createMinimal();
Review Comment:
Changed for local try-with-resources.
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestServerTest.java:
##########
@@ -199,12 +217,12 @@ public void checkCORSRequest(String corsDomain, String
origin, String expectedHe
HttpRequest request = new HttpGet("/connectors");
request.addHeader("Referer", origin + "/page");
request.addHeader("Origin", origin);
- CloseableHttpClient httpClient = HttpClients.createMinimal();
+ httpClient = HttpClients.createMinimal();
HttpHost httpHost = new HttpHost(
server.advertisedUrl().getHost(),
server.advertisedUrl().getPort()
);
- CloseableHttpResponse response = httpClient.execute(httpHost, request);
+ response = httpClient.execute(httpHost, request);
Review Comment:
Changed for local try-with-resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
