divijvaidya opened a new pull request, #12473: URL: https://github.com/apache/kafka/pull/12473
This PR is created on top of abandoned PR https://github.com/apache/kafka/pull/11137. I have added the previous author's comment in this PR for attribution. I have also addressed the pending comments from @mimaison in this PR. ## Notes to help the reviewer: - When we run the tests using @RunWith(MockitoJUnitRunner.StrictStubs.class) Mockito performs a verify() for all stubs that are mentioned, hence, there is no need to explicitly verify the stubs (unless you want to verify the number of times etc.). Note that this does not work for static mocks. ## Testing `./gradlew connect:runtime:unitTest --tests AbstractHerderTest` is successful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
