mdedetrich commented on code in PR #12475: URL: https://github.com/apache/kafka/pull/12475#discussion_r936511846
########## checkstyle/.scalafmt.conf: ########## @@ -12,7 +12,10 @@ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License. -docstrings = JavaDoc +version = 3.5.8 +runner.dialect = scala213 Review Comment: The Scala 2.13 dialect is backwards compatible with 2.12. I have applied the dialect when updating from scalafmt 2 to scalafmt 3 with various popular OSS Scala projects and there isn't any issues (in any case the Scala code that is used im Kafka is quite conservative) > I have verified that the style guide we follow for this project is not prescriptive about formatting of the docs. Hence, your change should be ok. Do you think it makes sense to format the docs or should I leave the PR as os? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
