jsancio commented on code in PR #12457:
URL: https://github.com/apache/kafka/pull/12457#discussion_r938879350
##########
raft/src/main/java/org/apache/kafka/raft/internals/RecordsIterator.java:
##########
@@ -180,6 +184,11 @@ private Optional<Batch<T>> nextBatch() {
}
private Batch<T> readBatch(DefaultRecordBatch batch) {
+ if (doCrcValidation) {
+ // Perform a CRC validity check on this batch
+ batch.ensureValid();
Review Comment:
This throws an exception that doesn't include a stacktrace. This is a rare
event so we want to pay the cost of generating a stacktrace as it will help us
debug the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
