cmccabe commented on PR #12486: URL: https://github.com/apache/kafka/pull/12486#issuecomment-1206848794
> Thanks @cmccabe, just one main question -- is it okay to break up an atomic batch into two Lists when writing to a snapshot? Do we ever rely on reading an atomic batch of messages as one List when reading snapshots? E.g., what happens if we're dealing with a topic with 2000 partitions. No, we do not rely on this in the snapshot. The decision of what batches to use in the snapshot doesn't change semantics. In the log (as opposed to snapshot) we care about batching because snapshots are atomically committed, so if the controller fails midway into writing a multibatch operation we have to think about what happens next (probably a partial commit of whatever was going on) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
