yashmayya commented on code in PR #12450:
URL: https://github.com/apache/kafka/pull/12450#discussion_r941408595
##########
docs/connect.html:
##########
@@ -440,19 +443,17 @@ <h5><a id="connect_connectorexample"
href="#connect_connectorexample">Connector
<pre class="brush: java;">
@Override
public List<Map<String, String>> taskConfigs(int maxTasks) {
+ // This method is where connectors provide the task configs for the tasks
that are to be created for this connector.
+ // The length of the list determines the number of tasks that need to be
created. The FileStreamSourceConnector, however, is
+ // only capable of spinning up a single task (since there isn't work that
can be distributed among multiple tasks).
+ // Note that the task configs could contain configs additional to or
different from the connector configs if needed (for instance,
+ // if different tasks have different responsibilities, or if different
tasks are meant to process different subsets of the source data stream).
Review Comment:
Ah, fair point. I've trimmed it down to couple of sentences.
##########
docs/connect.html:
##########
@@ -440,19 +443,17 @@ <h5><a id="connect_connectorexample"
href="#connect_connectorexample">Connector
<pre class="brush: java;">
@Override
public List<Map<String, String>> taskConfigs(int maxTasks) {
+ // This method is where connectors provide the task configs for the tasks
that are to be created for this connector.
+ // The length of the list determines the number of tasks that need to be
created. The FileStreamSourceConnector, however, is
+ // only capable of spinning up a single task (since there isn't work that
can be distributed among multiple tasks).
+ // Note that the task configs could contain configs additional to or
different from the connector configs if needed (for instance,
+ // if different tasks have different responsibilities, or if different
tasks are meant to process different subsets of the source data stream).
Review Comment:
Ah, fair point. I've trimmed it down to a couple of sentences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
