[
https://issues.apache.org/jira/browse/KAFKA-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385398#comment-16385398
]
ASF GitHub Bot commented on KAFKA-5660:
---------------------------------------
nafshartous opened a new pull request #4645: KAFKA-5660 Don't throw
TopologyBuilderException during runtime
URL: https://github.com/apache/kafka/pull/4645
KAFKA-5660 Don't throw TopologyBuilderException during runtime
Created this PR and after closing https://github.com/apache/kafka/pull/4605
due to conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Don't throw TopologyBuilderException during runtime
> ---------------------------------------------------
>
> Key: KAFKA-5660
> URL: https://issues.apache.org/jira/browse/KAFKA-5660
> Project: Kafka
> Issue Type: Task
> Components: streams
> Affects Versions: 0.11.0.0
> Reporter: Matthias J. Sax
> Assignee: Nick Afshartous
> Priority: Major
> Fix For: 1.2.0
>
>
> {{TopologyBuilderException}} is a pre-runtime exception that should only be
> thrown before {{KafkaStreams#start()}} is called.
> However, we do throw {{TopologyBuilderException}} within
> - `SourceNodeFactory#getTopics`
> - `ProcessorContextImpl#getStateStore`
> - `StreamPartitionAssignor#prepareTopic `
> (and maybe somewhere else: we should double check if there are other places
> in the code like those).
> We should replace those exception with either {{StreamsException}} or with a
> new exception type.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
