[
https://issues.apache.org/jira/browse/KAFKA-6589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386174#comment-16386174
]
ASF GitHub Bot commented on KAFKA-6589:
---------------------------------------
smurakozi opened a new pull request #4647: [WIP] KAFKA-6589 Extract Heartbeat
thread from AbstractCoordinator
URL: https://github.com/apache/kafka/pull/4647
AbstractCoordinator interacts with the thread via a HeartbeatThreadManager.
The existing behavior was extracted to an abstract class + some glue code in
the AbstractCoordinator.
Testing was done using the existing ConsumerCoordinatorTest and
WorkerCoordinatorTest.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Extract Heartbeat thread from Abstract Coordinator for testability purposes
> ---------------------------------------------------------------------------
>
> Key: KAFKA-6589
> URL: https://issues.apache.org/jira/browse/KAFKA-6589
> Project: Kafka
> Issue Type: Improvement
> Components: consumer
> Reporter: Guozhang Wang
> Assignee: Sandor Murakozi
> Priority: Minor
>
> Today we do not have an easy way to instrument the heartbeat thread in our
> unit test, e.g. to inject a GC or make it crash etc since it is a private
> class inside AbstractCoordinator.
> It is better to extract this class out and also enabling AbstractCoordinator
> to take a heartbeat-thread interface that can be mocked for test utils.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
