hachikuji commented on code in PR #12508:
URL: https://github.com/apache/kafka/pull/12508#discussion_r948534917
##########
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##########
@@ -778,4 +779,57 @@ class KRaftClusterTest {
cluster.close()
}
}
+ def createAdminClient(cluster: KafkaClusterTestKit): Admin = {
+ var props: Properties = null
+ props = cluster.clientProperties()
+ props.put(AdminClientConfig.CLIENT_ID_CONFIG, this.getClass.getName)
+ Admin.create(props)
+ }
+
+ @Test
+ def testDescribeQuorumRequestToBrokers() : Unit = {
+ val cluster = new KafkaClusterTestKit.Builder(
+ new TestKitNodes.Builder().
+ setNumBrokerNodes(4).
+ setNumControllerNodes(3).build()).build()
+ try {
+ cluster.format
+ cluster.startup
+ for (i <- 0 to 3) {
+ TestUtils.waitUntilTrue(() => cluster.brokers.get(i).brokerState ==
BrokerState.RUNNING,
+ "Broker Never started up")
+ }
+ val admin = createAdminClient(cluster)
+ try {
+ val quorumState = admin.describeMetadataQuorum(new
DescribeMetadataQuorumOptions)
+ val quorumInfo = quorumState.quorumInfo.get()
+
+ assertEquals(cluster.controllers.asScala.keySet,
quorumInfo.voters.asScala.map(_.replicaId).toSet)
+
assertTrue(cluster.controllers.asScala.keySet.contains(quorumInfo.leaderId),
+ s"Leader ID ${quorumInfo.leaderId} was not a controller ID.")
+
+ quorumInfo.voters.forEach { voter =>
+ assertTrue(0 < voter.logEndOffset,
+ s"logEndOffset for voter with ID ${voter.replicaId} was
${voter.logEndOffset}")
+ assertNotEquals(OptionalLong.empty(), voter.lastFetchTimeMs)
+ assertNotEquals(OptionalLong.empty(), voter.lastCaughtUpTimeMs)
+ }
+
+ assertEquals(cluster.brokers.asScala.keySet,
quorumInfo.observers.asScala.map(_.replicaId).toSet)
+ quorumInfo.observers.forEach { observer =>
+ assertTrue(0 < observer.logEndOffset,
+ s"logEndOffset for observer with ID ${observer.replicaId} was
${observer.logEndOffset}")
+ assertNotEquals(OptionalLong.empty(), observer.lastFetchTimeMs)
+ assertNotEquals(OptionalLong.empty(), observer.lastCaughtUpTimeMs)
+ }
+ } catch {
+ case t: Throwable => throw t
Review Comment:
nit: if we're just re-throwing, we don't need to catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
