divijvaidya commented on code in PR #12230:
URL: https://github.com/apache/kafka/pull/12230#discussion_r952378530
##########
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##########
@@ -463,8 +463,7 @@ public static <T> T newParameterizedInstance(String
className, Object... params)
throw new ClassNotFoundException(String.format("Unable to access "
+
"constructor of %s", className), e);
} catch (InvocationTargetException e) {
- throw new ClassNotFoundException(String.format("Unable to invoke "
+
- "constructor of %s", className), e);
+ throw new KafkaException(String.format("The constructor of %s
threw an exception", className), e.getCause());
Review Comment:
Wouldn't a `ClassNotFoundException` be wrong in this context and give a
wrong impression to user? I am saying this because it's not a problem with
Class not being on the JVM's classpath, instead `InvocationTargetException` is
thrown when we have found the Class and invoking the constructor is throwing an
exception in the line `constructor.newInstance(args`
I am happy to replace KafkaException with other generic RuntimeException
that you would suggest but `ClassNotFoundException` appears inappropriate to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
