mimaison commented on code in PR #12536:
URL: https://github.com/apache/kafka/pull/12536#discussion_r952552570
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java:
##########
@@ -409,6 +412,13 @@ public String groupId() {
return null;
}
+ public String kafkaClusterId() {
+ if (kafkaClusterId == null) {
+ kafkaClusterId = ConnectUtils.lookupKafkaClusterId(this);
+ }
+ return kafkaClusterId;
+ }
Review Comment:
That's a good idea. I've move `lookupKafkaClusterId` to `WorkerConfig`. We
should be able to make this method not public by updating some of the tests but
I've not done that since some of the callers are still using Easymock/Powermock
so they are being updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
