mimaison commented on code in PR #12473:
URL: https://github.com/apache/kafka/pull/12473#discussion_r952775683
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##########
@@ -141,89 +142,52 @@ public class AbstractHerderTest {
private final String connector = "connector";
private final ConnectorClientConfigOverridePolicy
noneConnectorClientConfigOverridePolicy = new
NoneConnectorClientConfigOverridePolicy();
- @MockStrict private Worker worker;
- @MockStrict private WorkerConfigTransformer transformer;
- @MockStrict private ConfigBackingStore configStore;
- @MockStrict private StatusBackingStore statusStore;
- @MockStrict private ClassLoader classLoader;
+ @Mock private Worker worker;
Review Comment:
My bad, somehow IDEA marked it as unused but as you said it is used!
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##########
@@ -141,89 +142,52 @@ public class AbstractHerderTest {
private final String connector = "connector";
private final ConnectorClientConfigOverridePolicy
noneConnectorClientConfigOverridePolicy = new
NoneConnectorClientConfigOverridePolicy();
- @MockStrict private Worker worker;
- @MockStrict private WorkerConfigTransformer transformer;
- @MockStrict private ConfigBackingStore configStore;
- @MockStrict private StatusBackingStore statusStore;
- @MockStrict private ClassLoader classLoader;
+ @Mock private Worker worker;
Review Comment:
My bad, somehow IDEA marked it as unused but, as you said, it is used!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
