divijvaidya commented on code in PR #12228:
URL: https://github.com/apache/kafka/pull/12228#discussion_r952819611
##########
clients/src/main/java/org/apache/kafka/common/security/authenticator/SaslClientAuthenticator.java:
##########
@@ -342,6 +342,7 @@ public void reauthenticate(ReauthenticationContext
reauthenticationContext) thro
reauthInfo.reauthenticating(apiVersionsResponseFromOriginalAuthentication,
reauthenticationContext.reauthenticationBeginNanos());
NetworkReceive netInBufferFromChannel =
reauthenticationContext.networkReceive();
+ resetNetworkIn(); // reset the buffer before new assignment
Review Comment:
In the very next line, we are overwriting the `netInBuffer` member and hence
losing it's earlier value without having closed it properly. Given the
sensitivity of the change in network component here, I am removing all changes
to this buffer from this PR to unblock it and will file a separate PR to
address this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
