hachikuji commented on code in PR #12513:
URL: https://github.com/apache/kafka/pull/12513#discussion_r954317998
##########
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##########
@@ -316,10 +326,12 @@ public boolean hasNext() {
public List<ApiMessageAndVersion> next() {
// Write the metadata.version first
if (!wroteVersion) {
- wroteVersion = true;
- return Collections.singletonList(new ApiMessageAndVersion(new
FeatureLevelRecord()
- .setName(MetadataVersion.FEATURE_NAME)
- .setFeatureLevel(metadataVersion.featureLevel()),
FEATURE_LEVEL_RECORD.lowestSupportedVersion()));
+ if (!metadataVersion.isLessThan(minimumBootstrapVersion)) {
Review Comment:
nit: i think this check reads easier as
`metadataVersion.isAtLeast(minimumBootstrapVersion)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
