[
https://issues.apache.org/jira/browse/KAFKA-14015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17582519#comment-17582519
]
Sagar Rao edited comment on KAFKA-14015 at 8/26/22 10:24 AM:
-------------------------------------------------------------
[~rozza] , Thanks for filing this issue. There seems to be a mismatch in what
the KIP talks about and what's happening in the code indeed. I think the
`restartConnectorAndTasks` was added well after the KIP was written. Just
curious, have you noticed that tasks continue working with outdated
configuration? In that case, does explicit restart of the task mitigate the
issue?
Also, one thing that I would like to point out is that we can't just replace
`restartConnector` call with `restartConnectorAndTasks` to get this working.
That's because the current `restartConnector` invocation doesn't restart
immediately but instead waits for ttl (which could be lease duration for vault
keys for example). In that case, we might need a new implementation of this.
What do you think about this [~ChrisE] , [~rayokota] , [~yash.mayya] ?
was (Author: sagarrao):
[~rozza] , Thanks for filing this issue. There seems to be a mismatch in what
the KIP talks about and what's happening in the code indeed. I think the
`restartConnectorAndTasks` was added well after the KIP was written. Just
curious, have you noticed that tasks continue working with outdated
configuration? In that case, does explicit restart of the task mitigate the
issue?
Also, one thing that I would like to point out is that we can't just replace
`restartConnector` call with `restartConnectorAndTasks` to get this working.
That's because the current `restartConnector` invocation doesn't restart
immediately but instead waits for ttl (which could be lease duration for vault
keys for example). In that case, we might need a new implementation of this.
What do you think about this [~ChrisE] , [~rayokota] ?
> ConfigProvider with ttl fails to restart tasks
> ----------------------------------------------
>
> Key: KAFKA-14015
> URL: https://issues.apache.org/jira/browse/KAFKA-14015
> Project: Kafka
> Issue Type: Bug
> Reporter: Ross Lawley
> Assignee: Sagar Rao
> Priority: Major
>
> According to the
> [KIP-297|https://cwiki.apache.org/confluence/display/KAFKA/KIP-297%3A+Externalizing+Secrets+for+Connect+Configurations#KIP297:ExternalizingSecretsforConnectConfigurations-SecretRotation]:
> {quote} * When the Herder receives the onChange() call, it will check a new
> connector configuration property config.reload.action which can be one of the
> following:
> ** The value restart, which means to schedule a restart of the Connector and
> all its Tasks. This will be the default.
> ** The value none, which means to do nothing.{quote}
> However, the
> [restartConnector|https://github.com/apache/kafka/blob/3.2.0/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java#L287-L294]
> method only restarts the connector and does not restart any tasks. Suggest
> calling {{restartConnectorAndTasks}} instead.
> The result is changed configurations provided by the ConfigProvider are not
> picked up and existing tasks continue to use outdated configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
