cadonna commented on code in PR #12583:
URL: https://github.com/apache/kafka/pull/12583#discussion_r964143315
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -610,73 +610,79 @@ private StreamTask convertStandbyToActive(final
StandbyTask standbyTask, final S
* @throws StreamsException if the store's change log does not contain the
partition
* @return {@code true} if all tasks are fully restored
*/
- boolean tryToCompleteRestoration(final long now, final
java.util.function.Consumer<Set<TopicPartition>> offsetResetter) {
- if (stateUpdater == null) {
- boolean allRunning = true;
+ boolean tryToCompleteRestoration(final long now,
Review Comment:
I pulled `changelogReader.enforceRestoreActive()` and
`changelogReader.transitToUpdateStandby()` from the stream thread into
`tryToCompleteRestoration()` and removed the `if`-statement that separated the
code path without the state updater from the code path with the state updater.
I extracted the code path with the state updater into `checkStateUpdater()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
