ijuma commented on code in PR #12590:
URL: https://github.com/apache/kafka/pull/12590#discussion_r968392833
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java:
##########
@@ -446,6 +429,31 @@ private RequestFuture<ClientResponse>
sendMetadataRequest(MetadataRequest.Builde
return client.send(node, request);
}
+ /**
+ * Send Fetch Request to Kafka cluster asynchronously.
+ *
+ * This method is visible for testing.
+ *
+ * @return A future that indicates result of sent Fetch request
+ */
+ RequestFuture<ClientResponse> sendFetchRequestToNode(final
FetchSessionHandler.FetchRequestData requestData,
+ final Node
fetchTarget) {
+ final short maxVersion = requestData.canUseTopicIds() ?
ApiKeys.FETCH.latestVersion() : (short) 12;
+
+ final FetchRequest.Builder request = FetchRequest.Builder
+ .forConsumer(maxVersion, this.maxWaitMs, this.minBytes,
requestData.toSend())
+ .isolationLevel(isolationLevel)
+ .setMaxBytes(this.maxBytes)
+ .metadata(requestData.metadata())
+ .removed(requestData.toForget())
+ .replaced(requestData.toReplace())
+ .rackId(clientRackId);
+
+ log.debug("Sending {} {} to broker {}", isolationLevel, requestData,
fetchTarget);
Review Comment:
To be clear, the reason the previous code had the `if` check is that it did
something expensive before calling `log.debug` (`data.toString()`). But that is
unnecessary since the logging library always calls `toString` anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
