vpapavas commented on code in PR #12555:
URL: https://github.com/apache/kafka/pull/12555#discussion_r969371482
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java:
##########
@@ -181,13 +181,22 @@ public <K, V1, V2, VOut> KStream<K, VOut> join(final
KStream<K, V1> lhs,
sharedTimeTracker
);
+ final KStreamKStreamSelfJoin<K, V1, V2, VOut> selfJoin = new
KStreamKStreamSelfJoin<>(
+ thisWindowStore.name(),
+ internalWindows,
+ joiner,
+ AbstractStream.reverseJoinerWithKey(joiner),
+ sharedTimeTracker
+ );
Review Comment:
Yes, unfortunately, this is done before the logical plan is created and
optimized and this is the only place where I can get the information needed to
create this node. I tried to do this when building the topology after the
rewriting but it was impossible without major refactoring as currently, there
is not a clear separation between logical and physical plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
