junrao commented on code in PR #12570:
URL: https://github.com/apache/kafka/pull/12570#discussion_r970263402
##########
clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java:
##########
@@ -1129,31 +1129,34 @@ public void onCompletion(RecordMetadata metadata,
Exception exception) {
assertEquals(1, mockRandom.get());
// Produce large record, we should exceed "sticky" limit, but
produce to this partition
- // as we switch after the "sticky" limit is exceeded. The
partition is switched after
- // we produce.
+ // as we try to switch after the "sticky" limit is exceeded. The
switch is disabled
+ // because of incomplete batch.
Review Comment:
I am trying to understand why the switch is disabled here. It seems that the
large record won't fit in the current batch. So, we will put the large record
in a new batch. This batch will then be full since the large record has more
than batch.size bytes in it. This should allow the switch, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
