[GitHub] [kafka] cadonna commented on a diff in pull request #12638: Register and unregister changelog topics in state updater

[GitBox]

cadonna commented on code in PR #12638:
URL: https://github.com/apache/kafka/pull/12638#discussion_r970629341


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java:
##########
@@ -575,8 +584,10 @@ public void close() throws ProcessorStateException {
     void recycle() {
         log.debug("Recycling state for {} task {}.", taskType, taskId);
 
-        final List<TopicPartition> allChangelogs = 
getAllChangelogTopicPartitions();
-        changelogReader.unregister(allChangelogs);
+        if (!stateUpdaterEnabled) {
+            final List<TopicPartition> allChangelogs = 
getAllChangelogTopicPartitions();
+            changelogReader.unregister(allChangelogs);
+        }

Review Comment:
   Note that once we have only the state updater recycling a state manager 
becomes a noop.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org