cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r970668525
########## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ########## @@ -421,73 +421,95 @@ private void classifyTasksWithoutStateUpdater(final Map<TaskId, Set<TopicPartiti } } - private void classifyRunningTasks(final Map<TaskId, Set<TopicPartition>> activeTasksToCreate, - final Map<TaskId, Set<TopicPartition>> standbyTasksToCreate, - final Map<Task, Set<TopicPartition>> tasksToRecycle, - final Set<Task> tasksToCloseClean) { + private void handleTasksWithStateUpdater(final Map<TaskId, Set<TopicPartition>> activeTasksToCreate, + final Map<TaskId, Set<TopicPartition>> standbyTasksToCreate, + final Map<Task, Set<TopicPartition>> tasksToRecycle, + final Set<Task> tasksToCloseClean) { + handleRunningAndSuspendedTasks(activeTasksToCreate, standbyTasksToCreate, tasksToRecycle, tasksToCloseClean); + handleTasksInStateUpdater(activeTasksToCreate, standbyTasksToCreate); + } + + private void handleRunningAndSuspendedTasks(final Map<TaskId, Set<TopicPartition>> activeTasksToCreate, + final Map<TaskId, Set<TopicPartition>> standbyTasksToCreate, + final Map<Task, Set<TopicPartition>> tasksToRecycle, + final Set<Task> tasksToCloseClean) { for (final Task task : tasks.allTasks()) { + if (!task.isActive()) { + throw new IllegalStateException("Standby tasks should only be managed by the state updater"); + } final TaskId taskId = task.id(); if (activeTasksToCreate.containsKey(taskId)) { - if (task.isActive()) { - final Set<TopicPartition> topicPartitions = activeTasksToCreate.get(taskId); - if (tasks.updateActiveTaskInputPartitions(task, topicPartitions)) { - task.updateInputPartitions(topicPartitions, topologyMetadata.nodeToSourceTopics(task.id())); - } - task.resume(); - } else { - throw new IllegalStateException("Standby tasks should only be managed by the state updater"); - } + handleReAssignedActiveTask(task, activeTasksToCreate.get(taskId)); activeTasksToCreate.remove(taskId); } else if (standbyTasksToCreate.containsKey(taskId)) { - if (!task.isActive()) { - throw new IllegalStateException("Standby tasks should only be managed by the state updater"); - } else { - tasksToRecycle.put(task, standbyTasksToCreate.get(taskId)); - } + tasksToRecycle.put(task, standbyTasksToCreate.get(taskId)); standbyTasksToCreate.remove(taskId); } else { tasksToCloseClean.add(task); } } } - private void classifyTasksWithStateUpdater(final Map<TaskId, Set<TopicPartition>> activeTasksToCreate, - final Map<TaskId, Set<TopicPartition>> standbyTasksToCreate, - final Map<Task, Set<TopicPartition>> tasksToRecycle, - final Set<Task> tasksToCloseClean) { - classifyRunningTasks(activeTasksToCreate, standbyTasksToCreate, tasksToRecycle, tasksToCloseClean); + private void handleReAssignedActiveTask(final Task task, + final Set<TopicPartition> inputPartitions) { + if (tasks.updateActiveTaskInputPartitions(task, inputPartitions)) { + task.updateInputPartitions(inputPartitions, topologyMetadata.nodeToSourceTopics(task.id())); + } + if (task.state() == State.SUSPENDED) { + task.resume(); + moveTaskFromTasksRegistryToStateUpdater(task); + } Review Comment: Could you elaborate why a suspended task cannot be reassigned as active with the cooperative assignor? Is this guaranteed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org