ijuma commented on code in PR #12636:
URL: https://github.com/apache/kafka/pull/12636#discussion_r971999299
##########
metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java:
##########
@@ -109,14 +110,9 @@ public class StandardAuthorizerData {
private final DefaultRule defaultRule;
/**
- * Contains all of the current ACLs sorted by (resource type, resource
name).
+ * An immutable array of all the current ACLs sorted by (resource type,
resource name).
*/
- private final ConcurrentSkipListSet<StandardAcl> aclsByResource;
Review Comment:
The downside of the current implementation is that updates can be pretty
expensive, right? Can we file a JIRA to investigate this further post 3.3?
##########
metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java:
##########
@@ -109,14 +110,9 @@ public class StandardAuthorizerData {
private final DefaultRule defaultRule;
/**
- * Contains all of the current ACLs sorted by (resource type, resource
name).
+ * An immutable array of all the current ACLs sorted by (resource type,
resource name).
*/
- private final ConcurrentSkipListSet<StandardAcl> aclsByResource;
Review Comment:
The downside of the current implementation is that updates can be pretty
expensive, right? Can we file a JIRA to investigate this further post 3.3.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
