cadonna commented on code in PR #12650:
URL: https://github.com/apache/kafka/pull/12650#discussion_r974112162
##########
streams/src/test/java/org/apache/kafka/streams/integration/RestoreIntegrationTest.java:
##########
@@ -291,8 +297,9 @@ public void shouldSuccessfullyStartWhenLoggingDisabled()
throws InterruptedExcep
assertTrue(startupLatch.await(30, TimeUnit.SECONDS));
}
- @Test
- public void shouldProcessDataFromStoresWithLoggingDisabled() throws
InterruptedException {
+ @ParameterizedTest
Review Comment:
In Junit 5 it is apparently not possible to parametrize on test class level.
However, you can use a method as the source for the parameter values `true` and
`false` for all test methods instead of enumerating `true` and `false` for each
test method. I used the method source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
