C0urante commented on code in PR #12656:
URL: https://github.com/apache/kafka/pull/12656#discussion_r974156910
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java:
##########
@@ -108,7 +108,7 @@ public class WorkerConfig extends AbstractConfig {
public static final String OFFSET_COMMIT_INTERVAL_MS_CONFIG =
"offset.flush.interval.ms";
private static final String OFFSET_COMMIT_INTERVAL_MS_DOC
- = "Interval at which to try committing offsets for tasks.";
+ = "Interval at which to try committing offsets for source tasks.";
Review Comment:
The offset commit interval also affects sink tasks; see here:
https://github.com/apache/kafka/blob/352c71ffb5d825c4a88454c12b9fa66c1750add3/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java#L212
We can probably revert this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
