philipnee commented on code in PR #12663: URL: https://github.com/apache/kafka/pull/12663#discussion_r975897905
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/EventHandler.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.clients.consumer.internals; + +/** + * The EventHandler interfaces the client and handler implementation. The client should add an event for consumption, + * and try to poll for the responses. Here, one could poll a response with type K, and add a request with type T. + * @param <T> Event request type + * @param <K> Event response type + */ +public interface EventHandler<T, K> { + public K poll(); + public boolean add(T event); Review Comment: Can we be more direct and call the ResponseEvent the BackgroundThreadEvent... because it really is coming from the background thread, and it's not necessary a NetworkEvent. It can be just a trigger for the callback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
