vvcephei commented on code in PR #12641:
URL: https://github.com/apache/kafka/pull/12641#discussion_r976572108
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -942,7 +942,7 @@ <h4><a class="toc-backref"
href="#id31">topology.optimization</a><a class="heade
<blockquote>
<div>
<p>
- You can tell Streams to apply topology optimizations by setting
this config. The optimizations are currently all or none and disabled by
default.
+ A configuration telling Kafka Streams if it should optimize the
topology and what optimizations to apply. Acceptable values are:
<code>NO_OPTIMIZATION</code>, <code>OPTIMIZE</code> or a comma separated list
of specific optimizations: (<code>REUSE_KTABLE_SOURCE_TOPICS</code>,
<code>MERGE_REPARTITION_TOPICS</code>).
These optimizations include moving/reducing repartition topics and
reusing the source topic as the changelog for source KTables. It is recommended
to enable this.
</p>
Review Comment:
```suggestion
These optimizations include moving/reducing repartition topics
and reusing the source topic as the changelog for source KTables. These
optimizations will save on network traffic and storage in Kafka without
changing the semantics of your applications. Enabling them is recommended.
</p>
```
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -424,8 +424,8 @@ <h4><a class="toc-backref"
href="#id23">num.standby.replicas</a><a class="header
</tr>
<tr class="row-even"><td>topology.optimization</td>
<td>Medium</td>
- <td colspan="2">A configuration telling Kafka Streams if it should
optimize the topology</td>
- <td>none</td>
+ <td colspan="2">A configuration telling Kafka Streams if it should
optimize the topology and what optimizations to apply. Acceptable values are:
<code>NO_OPTIMIZATION</code>, <code>OPTIMIZE</code> or a comma separated list
of specific optimizations: (<code>REUSE_KTABLE_SOURCE_TOPICS</code>,
<code>MERGE_REPARTITION_TOPICS</code>). </td>
Review Comment:
```suggestion
<td colspan="2">A configuration telling Kafka Streams if it
should optimize the topology and what optimizations to apply. Acceptable values
are: <code>StreamsConfig.NO_OPTIMIZATION</code> (<code>none</code>),
<code>StreamsConfig.OPTIMIZE</code> (<code>all</code>) or a comma separated
list of specific optimizations:
(<code>StreamsConfig.REUSE_KTABLE_SOURCE_TOPICS</code>
(<code>reuse.ktable.source.topics</code>),
<code>StreamsConfig.MERGE_REPARTITION_TOPICS</code>
(<code>merge.repartition.topics</code>)). </td>
```
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -942,7 +942,7 @@ <h4><a class="toc-backref"
href="#id31">topology.optimization</a><a class="heade
<blockquote>
<div>
<p>
- You can tell Streams to apply topology optimizations by setting
this config. The optimizations are currently all or none and disabled by
default.
+ A configuration telling Kafka Streams if it should optimize the
topology and what optimizations to apply. Acceptable values are:
<code>NO_OPTIMIZATION</code>, <code>OPTIMIZE</code> or a comma separated list
of specific optimizations: (<code>REUSE_KTABLE_SOURCE_TOPICS</code>,
<code>MERGE_REPARTITION_TOPICS</code>).
Review Comment:
```suggestion
A configuration telling Kafka Streams if it should optimize the
topology and what optimizations to apply. Acceptable values are:
<code>StreamsConfig.NO_OPTIMIZATION</code> (<code>none</code>),
<code>StreamsConfig.OPTIMIZE</code> (<code>all</code>) or a comma separated
list of specific optimizations:
(<code>StreamsConfig.REUSE_KTABLE_SOURCE_TOPICS</code>
(<code>reuse.ktable.source.topics</code>),
<code>StreamsConfig.MERGE_REPARTITION_TOPICS</code>
(<code>merge.repartition.topics</code>)).
</p>
<p>
We recommend listing specific optimizations in the config for
production code so that the structure of your topology will not change
unexpectedly during upgrades of the Streams library.
</p>
<p>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
