dajac commented on code in PR #12674:
URL: https://github.com/apache/kafka/pull/12674#discussion_r978308464
##########
core/src/test/scala/unit/kafka/server/FetchRequestTest.scala:
##########
@@ -285,8 +315,8 @@ class FetchRequestTest extends BaseFetchRequestTest {
// Check follower error codes
val followerId = TestUtils.findFollowerId(topicPartition, servers)
- assertResponseErrorForEpoch(Errors.NONE, followerId, Optional.empty())
- assertResponseErrorForEpoch(Errors.NONE, followerId,
Optional.of(secondLeaderEpoch))
+ assertResponseErrorForEpoch(Errors.NOT_LEADER_OR_FOLLOWER, followerId,
Optional.empty())
+ assertResponseErrorForEpoch(Errors.NOT_LEADER_OR_FOLLOWER, followerId,
Optional.of(secondLeaderEpoch))
Review Comment:
Yeah, I was thinking about this as well. The point is that this is the
correct and expected behavior in this case so I am inclined to keep it as it is
now. However, it would be great to have a test suite with a replica selector
enabled. I can do this as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
