mumrah commented on code in PR #12678:
URL: https://github.com/apache/kafka/pull/12678#discussion_r978741172


##########
docs/configuration.html:
##########
@@ -20,13 +20,22 @@
 
   <h3 class="anchor-heading"><a id="brokerconfigs" class="anchor-link"></a><a 
href="#brokerconfigs">3.1 Broker Configs</a></h3>
 
-  The essential configurations are the following:
+  For ZooKeeper clusters, brokers must have the following configuration:
   <ul>
-      <li><code>broker.id</code>
-      <li><code>log.dirs</code>
-      <li><code>zookeeper.connect</code>
+    <li><code>broker.id</code></li>
+    <li><code>log.dirs</code></li>
+    <li><code>zookeeper.connect</code></li>
   </ul>
 
+  For KRaft clusters, brokers and controllers must have the following 
configurations:
+  <ul>
+    <li><code>node.id</code></li>
+    <li><code>log.dirs</code></li>
+    <li><code>process.roles</code></li>
+  </ul>
+
+  On KRaft brokers, if <code>broker.id</code> is set, it must be equal to 
<code>node.id</code>.

Review Comment:
   The docs for the individual configs are included via `  <!--#include 
virtual="generated/kafka_config.html" -->`. We dynamically generate those from 
KafkaConfig.scala 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to