ASF GitHub Bot commented on KAFKA-6637:

huxihx opened a new pull request #4698: KAFKA-6637: Avoid divide /zero error 
with segment.ms set to zero
URL: https://github.com/apache/kafka/pull/4698
   Changes of this patch include:
   1. Avoid divide /zero error with segment.ms set to zero
   2. Ignore the effect of setting `log.roll.ms` to zero. Use `log.roll.hours` 
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> if set topic config segment.ms=0 Kafka broker won't be able to start
> --------------------------------------------------------------------
>                 Key: KAFKA-6637
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6637
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 1.0.0
>            Reporter: Chong Wang
>            Assignee: huxihx
>            Priority: Major
> If set topic config segment.ms to 0, Kafka server won't be able to start 
> because of a FATAL error:
> [2018-03-12 19:05:40,196] FATAL [KafkaServer id=2] Fatal error during 
> KafkaServer startup. Prepare to shutdown (kafka.server.KafkaServer) 
> java.lang.ArithmeticException: / by zero at 
> kafka.log.LogConfig.randomSegmentJitter(LogConfig.scala:100) at 
> kafka.log.Log.loadSegments(Log.scala:419) at 
> kafka.log.Log.<init>(Log.scala:203) at kafka.log.Log$.apply(Log.scala:1734) 
> at kafka.log.LogManager.kafka$log$LogManager$$loadLog(LogManager.scala:221) 
> at 
> kafka.log.LogManager$$anonfun$loadLogs$2$$anonfun$8$$anonfun$apply$16$$anonfun$apply$2.apply$mcV$sp(LogManager.scala:292)
>  at kafka.utils.CoreUtils$$anon$1.run(CoreUtils.scala:61) at 
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at 
> java.util.concurrent.FutureTask.run(FutureTask.java:266) at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748)
> [https://github.com/apache/kafka/blob/1.0/core/src/main/scala/kafka/log/LogConfig.scala#L100]
> So the minimum value shouldn't be 0
> https://kafka.apache.org/documentation/#topicconfigs

This message was sent by Atlassian JIRA

Reply via email to