divijvaidya commented on code in PR #12677:
URL: https://github.com/apache/kafka/pull/12677#discussion_r978873294
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerMetricsGroupTest.java:
##########
@@ -55,24 +54,19 @@ public class WorkerMetricsGroupTest {
private Sensor taskStartupSuccesses;
private Sensor taskStartupFailures;
- private ConnectorStatus.Listener delegateConnectorListener;
- private TaskStatus.Listener delegateTaskListener;
+ @Mock private ConnectorStatus.Listener delegateConnectorListener;
+ @Mock private TaskStatus.Listener delegateTaskListener;
@Before
public void setup() {
- connectMetrics = PowerMock.createMock(ConnectMetrics.class);
- ConnectMetricsRegistry connectMetricsRegistry =
PowerMock.createNiceMock(ConnectMetricsRegistry.class);
- ConnectMetrics.MetricGroup metricGroup =
PowerMock.createNiceMock(ConnectMetrics.MetricGroup.class);
+ ConnectMetricsRegistry connectMetricsRegistry =
mock(ConnectMetricsRegistry.class);
+ ConnectMetrics.MetricGroup metricGroup =
mock(ConnectMetrics.MetricGroup.class);
+ MetricName metricName = mock(MetricName.class);
- connectMetrics.registry();
- expectLastCall().andReturn(connectMetricsRegistry);
-
- connectMetrics.group(anyString());
- expectLastCall().andReturn(metricGroup);
-
- MetricName metricName = PowerMock.createMock(MetricName.class);
- metricGroup.metricName(anyObject(MetricNameTemplate.class));
- expectLastCall().andStubReturn(metricName);
+ when(metricGroup.metricName((MetricNameTemplate)
isNull())).thenReturn(metricName);
Review Comment:
Fixed in the new commit. Thank you for suggesting the comment itself. I
appreciate your detailed approach to code review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
