hachikuji commented on code in PR #12679:
URL: https://github.com/apache/kafka/pull/12679#discussion_r979119104
##########
docs/ops.html:
##########
@@ -1815,6 +1815,206 @@ <h4 class="anchor-heading"><a id="remote_jmx"
class="anchor-link"></a><a href="#
</tr>
</tbody></table>
+<h4 class="anchor-heading"><a id="kraft_monitoring" class="anchor-link"></a><a
href="#kraft_monitoring">KRaft Monitoring Metrics</a></h4>
+The set of metrics that allow monitoring of the KRaft quorum and the metadata
log.<br>
+Note: A Controller is defined as a Kafka Broker which has "controller"
included among the <code>process.roles</code> config
Review Comment:
How about this?
> Note that some of the exposed metrics depend on the role of the node as
defined by <code>process.roles</code>.
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -246,7 +246,9 @@ public KafkaRaftClient(
logContext,
random);
this.kafkaRaftMetrics = new KafkaRaftMetrics(metrics, "raft", quorum);
-
kafkaRaftMetrics.updateNumUnknownVoterConnections(quorum.remoteVoters().size());
+ // All Raft voters are statically configured and known at startup
+ // so there are no unknown voter connections. Report this metric as 0.
+ kafkaRaftMetrics.updateNumUnknownVoterConnections(0);
Review Comment:
Perhaps we should file a jira to follow up with removal of this metric if it
is not reporting anything useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
