divijvaidya commented on code in PR #12692:
URL: https://github.com/apache/kafka/pull/12692#discussion_r983414080
##########
raft/src/main/java/org/apache/kafka/raft/VotedState.java:
##########
@@ -92,11 +92,6 @@ public boolean hasElectionTimeoutExpired(long currentTimeMs)
{
return electionTimer.isExpired();
}
- public void overrideElectionTimeout(long currentTimeMs, long timeoutMs) {
Review Comment:
Yes code looks good from my side 👍
We need to re-run the tests since the build had a bunch of failures due to a
lingering thread. We expect this commit
https://github.com/apache/kafka/commit/09011da76d450f9a7dd11e159741f8e69cca115b
to mitigate the lingering thread problem and unblock the build. Please check if
you have this commit in your repo. If not, I would suggest to rebase this test
with `trunk` and run again. If you already have this commit, then we need to
ask a committer to re-run the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
