hachikuji commented on code in PR #12709:
URL: https://github.com/apache/kafka/pull/12709#discussion_r991457134
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -1318,7 +1318,52 @@ public void testFatalMetadataReplayErrorOnActive()
throws Throwable {
assertEquals(NullPointerException.class,
controlEnv.fatalFaultHandler().firstException().getCause().getClass());
controlEnv.fatalFaultHandler().setIgnore(true);
- controlEnv.metadataFaultHandler().setIgnore(true);
+ }
+ }
+
+ private final static List<ApiMessageAndVersion> CORRUPT_RECORD =
Review Comment:
nit: perhaps better to call this `INVALID_RECORD` with a brief comment
mentioning the topicId is not set. Also, since it's not used in any other
tests, maybe we can keep it local to `testFatalMetadataReplayErrorOnStandbys`?
It's always possible to factor it out if it does get used in other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
