OmniaGM commented on code in PR #12577:
URL: https://github.com/apache/kafka/pull/12577#discussion_r991569076
##########
connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/MirrorClient.java:
##########
@@ -56,7 +56,7 @@
public class MirrorClient implements AutoCloseable {
private static final Logger log =
LoggerFactory.getLogger(MirrorClient.class);
- private final AdminClient adminClient;
+ private final ForwardingAdmin adminClient;
Review Comment:
Also, the original MM2 codebase used to use Admin in the same places and
AdminClient in others. So `Admin` will be better for consistency.
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##########
@@ -47,7 +47,7 @@ public class MirrorCheckpointConnector extends
SourceConnector {
private Scheduler scheduler;
private MirrorConnectorConfig config;
private GroupFilter groupFilter;
- private AdminClient sourceAdminClient;
+ private ForwardingAdmin sourceAdminClient;
Review Comment:
Same as the other comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
