C0urante commented on code in PR #12561:
URL: https://github.com/apache/kafka/pull/12561#discussion_r994980800
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorIncrementalTest.java:
##########
@@ -517,13 +517,13 @@ public void testTaskAssignmentWhenWorkerBounces() {
leaderAssignment = deserializeAssignment(result, leaderId);
assertAssignment(leaderId, offset,
Collections.emptyList(), 0,
- Collections.emptyList(), 0,
+ Collections.emptyList(), 1,
Review Comment:
Hey @vamossagar12--I'd rather err on the side of not increasing the number
of rebalances required for simple cases like the one covered in
`WorkerCoordinatorIncrementalTest::testTaskAssignmentWhenWorkerBounces`.
I plan to file the downstream PR sometime next week. For ease of review I'd
prefer to keep it separate from this one, which has grown fairly large and
complex on its own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
