Stephan14 commented on code in PR #12308:
URL: https://github.com/apache/kafka/pull/12308#discussion_r996380503
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##########
@@ -1036,6 +1036,28 @@ class GroupCoordinatorTest {
assertEquals(Errors.NONE, syncGroupWithOldMemberIdResult.error)
}
+ @Test
+ def staticMemberJoinStorageWithUnknownPersistenceFailure(): Unit = {
+ val rebalanceResult = staticMembersJoinAndRebalance(leaderInstanceId,
followerInstanceId)
+ val joinGroupResult = staticJoinGroupWithPersistence(groupId,
JoinGroupRequest.UNKNOWN_MEMBER_ID, followerInstanceId, protocolType,
protocolSuperset, clockAdvance = 1, 2 * DefaultSessionTimeout, 2
*DefaultSessionTimeout, appendRecordError = Errors.MESSAGE_TOO_LARGE)
Review Comment:
Oh, I fix it
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##########
@@ -1036,6 +1036,28 @@ class GroupCoordinatorTest {
assertEquals(Errors.NONE, syncGroupWithOldMemberIdResult.error)
}
+ @Test
+ def staticMemberJoinStorageWithUnknownPersistenceFailure(): Unit = {
+ val rebalanceResult = staticMembersJoinAndRebalance(leaderInstanceId,
followerInstanceId)
+ val joinGroupResult = staticJoinGroupWithPersistence(groupId,
JoinGroupRequest.UNKNOWN_MEMBER_ID, followerInstanceId, protocolType,
protocolSuperset, clockAdvance = 1, 2 * DefaultSessionTimeout, 2
*DefaultSessionTimeout, appendRecordError = Errors.MESSAGE_TOO_LARGE)
+ checkJoinGroupResult(joinGroupResult,
+ Errors.UNKNOWN_SERVER_ERROR,
+ rebalanceResult.generation,
+ Set.empty,
+ Stable,
+ Some(protocolType))
+ assertNotEquals(None, groupCoordinator.groupManager.getGroup(groupId))
+ val group = groupCoordinator.groupManager.getGroup(groupId).get
+ val it = group.allMemberMetadata.iterator
+ while (it.hasNext) {
+ val member = it.next()
+ assertNotEquals(member.sessionTimeoutMs, 2 * DefaultSessionTimeout)
Review Comment:
Ok
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##########
@@ -1036,6 +1036,28 @@ class GroupCoordinatorTest {
assertEquals(Errors.NONE, syncGroupWithOldMemberIdResult.error)
}
+ @Test
+ def staticMemberJoinStorageWithUnknownPersistenceFailure(): Unit = {
+ val rebalanceResult = staticMembersJoinAndRebalance(leaderInstanceId,
followerInstanceId)
+ val joinGroupResult = staticJoinGroupWithPersistence(groupId,
JoinGroupRequest.UNKNOWN_MEMBER_ID, followerInstanceId, protocolType,
protocolSuperset, clockAdvance = 1, 2 * DefaultSessionTimeout, 2
*DefaultSessionTimeout, appendRecordError = Errors.MESSAGE_TOO_LARGE)
+ checkJoinGroupResult(joinGroupResult,
+ Errors.UNKNOWN_SERVER_ERROR,
+ rebalanceResult.generation,
+ Set.empty,
+ Stable,
+ Some(protocolType))
+ assertNotEquals(None, groupCoordinator.groupManager.getGroup(groupId))
Review Comment:
Fix it
##########
core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala:
##########
@@ -438,7 +440,7 @@ class GroupCoordinator(val brokerId: Int,
case None => group.currentState match {
case PreparingRebalance =>
val member = group.get(memberId)
- updateMemberAndRebalance(group, member, protocols, s"Member
${member.memberId} joining group during ${group.currentState}; client reason:
$reason", responseCallback)
+ updateMemberAndRebalance(group, member, protocols,
rebalanceTimeoutMs, sessionTimeoutMs, s"Member ${member.memberId} joining group
during ${group.currentState}; client reason: $reason", responseCallback)
Review Comment:
Yes
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##########
@@ -963,6 +963,8 @@ class GroupMetadataManagerTest {
assertEquals(Some(staticMemberId),
group.currentStaticMemberId(groupInstanceId))
}
+
+
Review Comment:
Revert it
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala:
##########
@@ -1036,6 +1036,28 @@ class GroupCoordinatorTest {
assertEquals(Errors.NONE, syncGroupWithOldMemberIdResult.error)
}
+ @Test
+ def staticMemberJoinStorageWithUnknownPersistenceFailure(): Unit = {
+ val rebalanceResult = staticMembersJoinAndRebalance(leaderInstanceId,
followerInstanceId)
+ val joinGroupResult = staticJoinGroupWithPersistence(groupId,
JoinGroupRequest.UNKNOWN_MEMBER_ID, followerInstanceId, protocolType,
protocolSuperset, clockAdvance = 1, 2 * DefaultSessionTimeout, 2
*DefaultSessionTimeout, appendRecordError = Errors.MESSAGE_TOO_LARGE)
+ checkJoinGroupResult(joinGroupResult,
+ Errors.UNKNOWN_SERVER_ERROR,
+ rebalanceResult.generation,
+ Set.empty,
+ Stable,
+ Some(protocolType))
+ assertNotEquals(None, groupCoordinator.groupManager.getGroup(groupId))
+ val group = groupCoordinator.groupManager.getGroup(groupId).get
+ val it = group.allMemberMetadata.iterator
+ while (it.hasNext) {
+ val member = it.next()
+ assertNotEquals(member.sessionTimeoutMs, 2 * DefaultSessionTimeout)
+ assertEquals(member.sessionTimeoutMs, DefaultSessionTimeout)
+ assertNotEquals(member.rebalanceTimeoutMs, 2 * DefaultRebalanceTimeout)
+ assertEquals(member.rebalanceTimeoutMs, DefaultRebalanceTimeout)
+ }
+ }
+
Review Comment:
I Have add a test `staticMemberJoinStorageWithUnknownPersistenceSuccess`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
