showuon commented on code in PR #12711:
URL: https://github.com/apache/kafka/pull/12711#discussion_r996824526
##########
metadata/src/main/java/org/apache/kafka/metadata/util/SnapshotFileReader.java:
##########
@@ -131,6 +132,10 @@ private void handleControlBatch(FileChannelRecordBatch
batch) {
batch.partitionLeaderEpoch()
));
break;
Review Comment:
Good point. For (1), the snapshotFileReader is also used to read log file in
metadata shell. But still, we might not need to read and handle this message
here. Created https://issues.apache.org/jira/browse/KAFKA-14308 for this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
