OmniaGM commented on PR #12366: URL: https://github.com/apache/kafka/pull/12366#issuecomment-1288227815
> @OmniaGM You've been active recently with MirrorMaker 2 and seem quite familiar with it. Would you be willing to give this a review? I'd love it if someone could fact-check here and make sure that the MM2-specific details are correct. > > For reference: > > * Docs for `SourceConnector::exactlyOnceSupport`: https://github.com/apache/kafka/blob/679e9e0cee67e7d3d2ece204a421ea7da31d73e9/connect/api/src/main/java/org/apache/kafka/connect/source/SourceConnector.java#L34-L54 > > * Docs and other useful info on the `exactly.once.support` connector property: https://github.com/apache/kafka/blob/679e9e0cee67e7d3d2ece204a421ea7da31d73e9/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SourceConnectorConfig.java#L60-L84 Hi sorry for the very late respond on this. I have the following question: - What is the side effect of enabling `exactly.once.source.support=enabled` and `consumer.isolation.level=READ_COMMITTED` on the other `SourceConnector`s in MM2 like `MirrorHeartbeatConnector` and `MirrorCheckpointConnector` (both have no needs to be EOS). Will these also be EOS as well if the `MirrorSourceConnector` is configured to be EOS? If this is the case then KIP-618 need to mention this or/and update MM2 README.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
