mdedetrich commented on code in PR #12781:
URL: https://github.com/apache/kafka/pull/12781#discussion_r1006635305
##########
connect/runtime/src/test/java/org/apache/kafka/connect/util/KafkaBasedLogTest.java:
##########
@@ -115,10 +115,32 @@ public class KafkaBasedLogTest {
private static final String TP1_VALUE_NEW = "VAL1_NEW";
private Time time = new MockTime();
- private KafkaBasedLog<String, String> store;
+
+ private class MockedKafkaBasedLog extends KafkaBasedLog<String, String> {
+ public MockedKafkaBasedLog(String topic,
+ Map<String, Object> producerConfigs,
+ Map<String, Object> consumerConfigs,
+ Supplier<TopicAdmin> topicAdminSupplier,
+ Callback<ConsumerRecord<String, String>>
consumedCallback,
+ Time time,
+ Consumer<TopicAdmin> initializer) {
+ super(topic, producerConfigs, consumerConfigs, topicAdminSupplier,
consumedCallback, time, initializer);
+ }
+
+ @Override
+ protected KafkaProducer<String, String> createProducer() {
+ return producer;
+ }
+
+ @Override
+ protected MockConsumer<String, String> createConsumer() {
+ return consumer;
+ }
+ }
+ private MockedKafkaBasedLog store;
@Mock
- private Runnable initializer;
+ private Consumer<TopicAdmin> initializer;
Review Comment:
As pointed out by @gharris1727 , the type of `initializer` had to be changed
because it was in fact incorrect. I have no idea how this happened to work
beforehand with EasyMock, but this appears to work alongside with changing
`expectStart` to `verify(initializer).accept(any());` (since we have a
`Supplier` and not a `Runnable`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
