dengziming commented on code in PR #12790:
URL: https://github.com/apache/kafka/pull/12790#discussion_r1006976348
##########
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##########
@@ -470,6 +471,30 @@ class TopicCommandIntegrationTest extends
KafkaServerTestHarness with Logging wi
TestUtils.verifyTopicDeletion(zkClientOrNull, testTopicName, 1, brokers)
}
+ @ParameterizedTest(name = TestInfoUtils.TestWithParameterizedQuorumName)
+ @ValueSource(strings = Array("zk", "kraft"))
+ def testTopicWithCollidingCharDeletionAndCreateAgain(quorum: String): Unit =
{
+ // create the topic with colliding chars
+ val topicWithCollidingChar = "test.a"
+ val createOpts = new TopicCommandOptions(Array("--partitions", "1",
+ "--replication-factor", "1",
+ "--topic", topicWithCollidingChar))
+ createAndWaitTopic(createOpts)
+
+ // delete the topic
+ val deleteOpts = new TopicCommandOptions(Array("--topic",
topicWithCollidingChar))
+
+ if (!isKRaftTest()) {
+ val deletePath = DeleteTopicsTopicZNode.path(topicWithCollidingChar)
+ assertFalse(zkClient.pathExists(deletePath), "Delete path for topic
shouldn't exist before deletion.")
+ }
+ topicService.deleteTopic(deleteOpts)
+ TestUtils.verifyTopicDeletion(zkClientOrNull, topicWithCollidingChar, 1,
brokers)
+
+ val createTopic: Executable = () => createAndWaitTopic(createOpts)
+ assertDoesNotThrow(createTopic)
Review Comment:
I'm investigating why there will be compile error when directly using
`assertDoesNotThrow(() => createAndWaitTopic(createOpts))`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
