jolshan commented on code in PR #12149:
URL: https://github.com/apache/kafka/pull/12149#discussion_r1007207887


##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -155,7 +155,7 @@ private enum State {
         private boolean isTransitionValid(State source, State target) {
             switch (target) {
                 case UNINITIALIZED:
-                    return source == READY;
+                    return source == READY || source == ABORTABLE_ERROR;

Review Comment:
   Hmmm. I see. I'm just wondering if we are hijacking the current state 
machine in an unexpected way and if there are implications there. I suppose we 
are only following this path on these specific error types, but I wonder if we 
are missing anything existing by changing the valid transitions and/or opening 
up the potential for something else in the future. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to