philipnee commented on code in PR #12545:
URL: https://github.com/apache/kafka/pull/12545#discussion_r1008966693
##########
clients/src/main/java/org/apache/kafka/common/serialization/Deserializer.java:
##########
@@ -60,6 +62,17 @@ default T deserialize(String topic, Headers headers, byte[]
data) {
return deserialize(topic, data);
}
+ /**
+ * Deserialize a record value from a ByteBuffer into a value or object.
+ * @param topic topic associated with the data
+ * @param headers headers associated with the record; may be empty.
Review Comment:
sorry, not super familiar with the Headers class, assume empty is not null?
It would be good to clarify here in case if user think empty = null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
