lucasbru commented on PR #12795: URL: https://github.com/apache/kafka/pull/12795#issuecomment-1298912142
If that is the case, especially if it takes a long time to init rocksdb, maybe it would be the br see to initialize the state in the state updater instead? Bruno Cadonna ***@***.***> schrieb am Di., 1. Nov. 2022, 18:56: > ***@***.**** commented on this pull request. > ------------------------------ > > In > streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java > <https://github.com/apache/kafka/pull/12795#discussion_r1010735950>: > > > + Stream.concat(newActiveTasks.stream(), newStandbyTask.stream()) > + .forEach(t -> addTaskToStateUpdater(t, taskInitExceptions)); > > When I started working on the state updater I had the same thought, but > then I learned that task initialization might take some time due to the > need of opening RocksDB instances. Having such time consuming operations on > the rebalance path is not ideal. I do not remember exactly the reason, but > I think with cooperative rebalancing the client might miss the immediate > next rebalance which would lead again to more rebalances. > @ableegoldman <https://github.com/ableegoldman> Please keep me honest > here. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/kafka/pull/12795#pullrequestreview-1163800699>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAMNTXICWYUQX3JISGQEIELWGFKVFANCNFSM6AAAAAARRHHEBI> > . > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
