[
https://issues.apache.org/jira/browse/KAFKA-6676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403741#comment-16403741
]
ASF GitHub Bot commented on KAFKA-6676:
---------------------------------------
ewencp opened a new pull request #4729: KAFKA-6676: Ensure Kafka chroot exists
in system tests and use chroot on one test with security parameterizations
URL: https://github.com/apache/kafka/pull/4729
Ensures Kafka chroot exists in ZK when starting KafkaService so commands
that use ZK and are executed before the first Kafka broker starts do not fail
due to the missing chroot.
Also uses chroot with one test that also has security parameterizations so
Kafka's test suite exercises these combinations. Previously no tests were
exercising chroots.
To validate, I kicked off a [test
run](https://jenkins.confluent.io/job/system-test-kafka-branch-builder/1483/)
of the sanity_checks (which include the chroot-ed test as well as some
non-chroot-ed tests).
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> System tests do not handle ZK chroot properly with SCRAM
> --------------------------------------------------------
>
> Key: KAFKA-6676
> URL: https://issues.apache.org/jira/browse/KAFKA-6676
> Project: Kafka
> Issue Type: Bug
> Reporter: Ewen Cheslack-Postava
> Assignee: Ewen Cheslack-Postava
> Priority: Major
>
> This is related to the issue observed in KAFKA-6672. There, we are now
> automatically creating parent nodes if they do not exist. However, if using a
> chroot within ZK and that chroot does not yet exist, you get an error message
> about "Path length must be > 0" as it tries to create all the parent paths.
> It would probably be better to be able to detect this issue and account for
> it, but currently system test code will fail if you use SCRAM and a chroot
> because while Kafka will create the chroot when it starts up, there are some
> commands related to security that may need to be executed before that and
> assume the chroot will already be there.
> We're currently missing this because while the chroot option is there,
> nothing in Kafka's tests are currently exercising it. So given what is
> apparently a common assumption in tools that the chroot already exists (since
> I think the core kafka server is the only thing that handles creating it if
> needed), I think the fix here would be two-fold:
> # Make KafkaService ensure the chroot exists before running any commands
> that might need it.
> # On at least one test that exercises security support, use a zk_chroot so
> that functionality is at least reasonably well exercised.
> It would be good to have this in both trunk and 1.1 branches.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
