C0urante commented on code in PR #12233:
URL: https://github.com/apache/kafka/pull/12233#discussion_r1023143304
##########
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##########
@@ -142,26 +142,40 @@ public static String randomString(final int len) {
}
/**
- * Create an empty file in the default temporary-file directory, using
`kafka` as the prefix and `tmp` as the
- * suffix to generate its name.
+ * Create an empty file in the default temporary-file directory, using the
given prefix and suffix
+ * to generate its name.
+ * @throws IOException
*/
- public static File tempFile() throws IOException {
- final File file = File.createTempFile("kafka", ".tmp");
+ public static File tempFile(final String prefix, final String suffix)
throws IOException {
+ final File file = Files.createTempFile(prefix, suffix).toFile();
file.deleteOnExit();
+ Exit.addShutdownHook("delete-temp-file-shutdown-hook", () -> {
Review Comment:
@divijvaidya I've come across this while doing research for an unrelated PR;
sorry to comment so late.
Do you know why we use `Exit::addShutdownHook` here instead of invoking
`Runtime.getRuntime().addShutdownHook` directly? If we've overridden the
shutdown hook behavior in the `Exit` class during testing (which we don't do
anywhere in the code base ATM, but may do at some point in the future), then
won't this shutdown hook be potentially disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
