jonathan-albrecht-ibm commented on code in PR #12343:
URL: https://github.com/apache/kafka/pull/12343#discussion_r1024086819
##########
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##########
@@ -2263,7 +2263,10 @@ public void configure(Map<String, ?> configs) {
private Sender sender = mock(Sender.class);
private TransactionManager transactionManager =
mock(TransactionManager.class);
private Partitioner partitioner = mock(Partitioner.class);
- private KafkaThread ioThread = mock(KafkaThread.class);
+ private KafkaThread ioThread = new KafkaThread("Fake Kafka Producer
I/O Thread", new Runnable() {
+ @Override
+ public void run() {}
+ }, true);
Review Comment:
I have run the test again without this change and it looks like it is no
longer needed. I see that mockito has been upgraded to newer releases a few
times since this PR was created so I'm guessing that has fixed this problem.
I'll push an amended commit to remove this change but let me know if the
kafka developers prefer adding a new commit to remove it instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
