ableegoldman commented on code in PR #12869:
URL: https://github.com/apache/kafka/pull/12869#discussion_r1025891177
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -611,9 +616,11 @@ boolean runLoop() {
cacheResizer.accept(size);
}
runOnce();
- if (nextProbingRebalanceMs.get() < time.milliseconds()) {
+
+ // Check for a scheduled rebalance but don't trigger it until
the current rebalance is done
+ if (!taskManager.rebalanceInProgress() &&
nextProbingRebalanceMs.get() < time.milliseconds()) {
Review Comment:
Yes, but in those cases we should actually not have triggered the rebalance
anyway -- this should always reflect the latest status of whether a rebalance
is actually needed.
And yeah, I'll remove all the thread id stuff but since there's not much
other junk left once that's removed, I would rather keep the minor renaming of
`isRebalanceInProgress` if that's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
